chore(ci): misc improvments in CI permutations #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
chore/change-ci-permutations
branch
3 times, most recently
from
a92302b to
32a30e7
Compare
nikophil
force-pushed
the
chore/change-ci-permutations
branch
2 times, most recently
from
efee0b3 to
343a5bb
Compare
nikophil
changed the title
nikophil
commented
Jan 30, 2025
| @@ -68,7 +67,7 @@ final protected function dropAndResetDatabase(Application $application): void | |||
| // let's only drop the .db file | |||
|
|
|||
| $dbPath = $connection->getParams()['path'] ?? null; | |||
| if (DoctrineOrmVersionGuesser::isOrmV3() && $dbPath && (new Filesystem())->exists($dbPath)) { | |||
There was a problem hiding this comment.
this test on orm version seems to not be needed anymore
nikophil
commented
Jan 30, 2025
| @@ -20,7 +20,7 @@ | |||
| * @author Nicolas PHILIPPE <[email protected]> | |||
| */ | |||
| #[ORM\Entity] | |||
| #[ORM\Table('inversed_one_to_one_with_non_nullable_owning_inverse_side')] | |||
| #[ORM\Table('inversed_one_to_one_non_nullable_owning_inverse_side')] | |||
There was a problem hiding this comment.
the name was too long for PG sequences 😅
nikophil
force-pushed
the
chore/change-ci-permutations
branch
5 times, most recently
from
b726ae0 to
c46c240
Compare
nikophil
force-pushed
the
chore/change-ci-permutations
branch
from
c46c240 to
6d52a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #796
fixes #783
on
2.xbranch, we currently have 31 permutations for reset database testsuite and 48 for main testsuite, running in 9m50and now we have 35 permutations for reset database testsuite and 24 for main testsuite, running in 4m21 😊